Closed
Bug 620408
Opened 14 years ago
Closed 14 years ago
add fall through comment to txXPCOMExtensionFunctionCall::GetParamType
Categories
(Core :: XSLT, enhancement)
Core
XSLT
Tracking
()
RESOLVED
FIXED
mozilla5
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug)
Details
(Keywords: coverity)
Attachments
(1 file)
|
625 bytes,
patch
|
peterv
:
review+
jst
:
approval2.0-
|
Details | Diff | Splinter Review |
293 txXPCOMExtensionFunctionCall::GetParamType(const nsXPTParamInfo &aParam,
294 nsIInterfaceInfo *aInfo)
295 {
296 PRUint8 tag = aParam.GetType().TagPart();
297 switch (tag) {
305 case nsXPTType::T_INTERFACE_IS:
306 {
315 if (iid.Equals(NS_GET_IID(txIXPathObject))) {
316 return eOBJECT;
317 }
318 }
a fall through comment here would help tools/readers
319 default:
320 {
321 // XXX Error!
322 return eUNKNOWN;
323 }
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #498894 -
Flags: review?(peterv)
Attachment #498894 -
Flags: approval2.0?
|
||
Comment 2•14 years ago
|
||
Comment on attachment 498894 [details] [diff] [review]
add fallthrough comment
Pfff, what a waste of time.
Attachment #498894 -
Flags: review?(peterv) → review+
|
||
Comment 3•14 years ago
|
||
Comment on attachment 498894 [details] [diff] [review]
add fallthrough comment
Mass minusing patch approval that don't have high return. Please renominate if this is more important for 2.0 than it appears.
Attachment #498894 -
Flags: approval2.0? → approval2.0-
|
||
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
|
||
Updated•7 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•